Add unit tests and clean up dependencies #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR restructures the pane-registry package by moving source files into a src/ directory, adding comprehensive test coverage with Jest, and updating the build/lint configuration. The main purpose is to improve code organization, testing infrastructure, and development workflow.
Key Changes:
- Moved paneRegistry.js and index.d.ts into src/ directory with updated package.json entry points
- Added Jest-based test suite with 100% code coverage and Jest configuration
- Updated ESLint configuration with separate rules for source and test files
Reviewed Changes
Copilot reviewed 5 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/paneRegistry.js | Core registry implementation moved to src/ directory |
| src/index.d.ts | TypeScript definitions moved to src/ directory |
| package.json | Updated entry points, changed dependencies to peerDependencies, added Jest, removed Husky |
| jest.config.js | New Jest configuration for testing with coverage reporting |
| eslint.config.mjs | Enhanced ESLint configuration with separate rules for source and test files |
| tests/paneRegistry.test.js | New comprehensive test suite covering all registry functionality |
| TESTING.md | New documentation for testing procedures and coverage |
| .github/workflows/ci.yml | Removed Node.js 18.x from CI matrix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds comprehensive test suite with 100% coverage and removes unused dependencies.
Changes
Added 22 unit tests for all pane-registry functionality
100% test coverage (statements, branches, functions, lines)
Removed unused devDependencies to reduce package size
Tests cover: registration, lookup, error handling, console logging
Test Examples
Results
✅ All 22 tests passing
✅ 100% code coverage
✅ Cleaner dependency list
✅ No breaking changes
Type: Testing + Cleanup
Version: 2.5.1